Repository navigation
Conversation
When the virtual go module records its implied toolchain requirement, map Go 1.21+ language versions to the first concrete toolchain version. This prevents go get go from writing toolchain lines such as go1.23, which are invalid toolchain names. Fixes golang#82077.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: de2c610) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/846845. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/846845. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/846845. |
|
Message from Weidong He: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/846845. |
When the virtual go module records its implied toolchain requirement,
map Go 1.21 and later language versions to the first concrete toolchain
version. For example, map go 1.23 to toolchain go1.23.0, not go1.23.
This prevents go get go from writing an invalid toolchain line when an
older target go version preserves the original go line's implied toolchain
requirement.
Reuse this mapping in startup toolchain selection and in go.mod/go.work
writeback checks.
Fixes #82077.